GetMatchingBrowserVersion for other browsers #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DAud-IcI Thanks for the pull request! I'll take a look in a few days, hopfully in a one or two |
rosolko
reviewed
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the missing
IDriverConfig.GetMatchingBrowserVersionTestimplementations for Firefox and IE. Also I made ChromeConfig usechromiumas a fallback on Linux (it seems like chromedriver happily callschromiumif only that's available, so it was only a problem for the version getter logic). I have verified that they get the desired output on Windows 10 and Arch Linux.This is based on my current project in improving Lombiq UI Testing Toolkit here