forked from mileperhour/localtuya-homeassistant
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inlang
to make the contribution of translations easier
#1377
Open
felixhaeberle
wants to merge
156
commits into
rospogrigio:master
Choose a base branch
from
felixhaeberle:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rospogrigio Hey, just wanted to check-in if you want to improve the localization in your project? Let me know how I can further assist ✨ |
I really like this PR, can you document it in the README.md and info.md and as you proposed? |
@rospogrigio Thank you, will do a follow-up PR with the info 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what changes you request for merging this PR.
Description
This pull request adds the possibility for contributors and translators to manage translations in a UI instead of files with no overhead for the maintainers. Additionally, I fixed some translations and added the German (de) language.
To get a UI for translations contained in this repository, an inlang.config.js has been created at the root of the repository. Furthermore, I added the few missing translations. If you want, I can add a small i18n section to the documentation on the README.
Overview
The changes of this PR and a live instance of the editor can be previewed with the following link https://inlang.com/editor/github.com/felixhaeberle/localtuya.
Note: This link should be changed to point to
rospogrigio
instead offelixhaeberle
after this PR has been merged.Limitations
Certain actions are slow
Inlang is running entirely on git, giving tremendous CI/CD and contribution power to localization. That means that the whole
localtuya
repo is cloned into the browser which makes certain actions like the initial load and pushing changes slow. Those limitations will be fixed with future releases and require no input fromlocaltuya
.Preview
Preview the messages on https://inlang.com/editor/github.com/felixhaeberle/localtuya.