Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly close discovery listeners #225

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Properly close discovery listeners #225

merged 1 commit into from
Dec 7, 2020

Conversation

postlund
Copy link
Collaborator

@postlund postlund commented Dec 7, 2020

Fixes #214

@postlund postlund added the bug Something isn't working label Dec 7, 2020
ultratoto14
ultratoto14 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@ultratoto14 ultratoto14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@postlund postlund merged commit b50ee8b into master Dec 7, 2020
@postlund postlund deleted the fix_discovery branch December 7, 2020 21:20
@postlund postlund mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultratoto14 ultratoto14 ultratoto14 approved these changes

@rospogrigio rospogrigio Awaiting requested review from rospogrigio

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems to discover
2 participants
@postlund @ultratoto14