-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Actions setup and test config #55
Fix GitHub Actions setup and test config #55
Conversation
Perhaps old versions of Python like 2.7, 3.5, 3.6, may be dropped? |
4c54d8e
to
cdbf79d
Compare
Done. |
cdbf79d
to
e71e43b
Compare
Per the most recent GitHub Actions run, fix the setup and test commands: * remove `--use-mirrors` flag from the `pip` command as it's no longer a valid option [failed pip run](https://github.com/rossant/ipycache/runs/4766646133) * remove old Python versions (2.7, 3.3, 3.4, 3.5, 3.6) * Python 3.3 and 3.4 are not available on macOS ([failed Python 3.3 install], [failed Python 3.4 install]) Python 3.10 was removed since `nosetests` is not compatible with it, nor is it maintained any more. We will need to migrate to nose2 or pytest instead. The list of [available Python versions] shows provided Python versions. Minor changes: * add Ubuntu 18.04 LTS to the list of OS versions in case folks still use it, since it's still supported and may be in use * explicitly specify the `x64` architecture to clarify that we're running in 64-bit mode (also the default), as opposed to `x86` which would run in 32-bit mode Closes rossant#52 [failed pip run]: https://github.com/rossant/ipycache/runs/4766646133 [failed Python 3.3 install]: https://github.com/rossant/ipycache/runs/4766646186 [failed Python 3.4 install]: https://github.com/rossant/ipycache/runs/4766646247 [available Python versions]: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
e71e43b
to
49a47a5
Compare
@rossant — since we've removed testing with Python 2.7, should we also remove special-casing for Python 2 (see below), or should we bring back the tests for Python 2.7 to keep backwards-compatibility? I know Python 2.x was EOL as of Jan 2020, but maybe some folks somewhere are still depending on using it (somehow)? Lines 28 to 52 in ebefe10
|
I think it's fine to drop Python 2.x support. Maybe add a tag before doing it to be on the safe side.. |
Per the most recent GitHub Actions run, fix the setup and test commands:
--use-mirrors
flag from thepip
command as it's no longer a validoption failed pip run
on macOS (failed Python 3.3 install, failed Python 3.4 install)
The list of available Python versions shows Python 3.5 and later are provided.
Minor changes:
it, since it's still supported and may be in use
x64
architecture to clarify that we're running in64-bit mode (also the default), as opposed to
x86
which would run in 32-bitmode
Closes #52