Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loose teams #133

Merged
merged 21 commits into from
Sep 19, 2020
Merged

Loose teams #133

merged 21 commits into from
Sep 19, 2020

Conversation

rossjrw
Copy link
Owner

@rossjrw rossjrw commented Sep 18, 2020

Sorting players by alphabet was always a stupid idea. As of right now there's 23 unsuccessful moves to 60 total moves, indicating that it is not intuitive and overall a bad idea.

Instead, players should not be grouped into a team until they have played a game. At that point they should be locked into that team until the game ends.

  • Team check can return null
  • Handle null case when team check is made
  • Use game state to derive teams instead of the alphabet
  • Update prose everywhere to reflect new selection system
  • Update messages e.g. in new issues to reflect team joining/team participation
  • Add a 'who's on each team' to the README

Closes #53.

@rossjrw rossjrw marked this pull request as ready for review September 19, 2020 08:31
@rossjrw rossjrw merged commit 6e8bd8f into source Sep 19, 2020
@rossjrw rossjrw mentioned this pull request Sep 19, 2020
@rossjrw rossjrw deleted the loose-teams branch September 19, 2020 09:44
rossjrw added a commit that referenced this pull request Oct 30, 2021
It has not been relevant for a long time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant