Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize TheGraph for Aave. Also support Aave borrowing. #1545

Merged
merged 20 commits into from
Oct 19, 2020

Conversation

LefterisJP
Copy link
Member

@LefterisJP LefterisJP commented Oct 4, 2020

Fix #1458. Should also add Aave borrowing events.

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #1545 into develop will decrease coverage by 0.11%.
The diff coverage is 78.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1545      +/-   ##
===========================================
- Coverage    71.49%   71.37%   -0.12%     
===========================================
  Files          359      363       +4     
  Lines        19527    20027     +500     
  Branches      2778     2862      +84     
===========================================
+ Hits         13960    14294     +334     
- Misses        4841     4968     +127     
- Partials       726      765      +39     
Flag Coverage Δ
#backend 80.65% <78.37%> (-0.50%) ⬇️
#frontend_integration 51.07% <ø> (+0.02%) ⬆️
#frontend_unit 23.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rotkehlchen/api/rest.py 84.33% <ø> (-0.47%) ⬇️
rotkehlchen/db/schema.py 100.00% <ø> (ø)
rotkehlchen/history/trades.py 53.27% <0.00%> (-0.89%) ⬇️
rotkehlchen/accounting/structures.py 70.12% <33.33%> (-1.50%) ⬇️
rotkehlchen/serialization/deserialize.py 84.03% <50.00%> (-1.07%) ⬇️
rotkehlchen/chain/ethereum/aave/blockchain.py 60.83% <61.90%> (ø)
rotkehlchen/chain/ethereum/compound.py 79.10% <64.28%> (-2.58%) ⬇️
rotkehlchen/chain/ethereum/aave/graph.py 74.34% <74.34%> (ø)
rotkehlchen/chain/ethereum/aave/__init__.py 79.31% <79.31%> (ø)
rotkehlchen/db/upgrades/v18_v19.py 80.00% <80.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855d932...c9034b4. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2020

This pull request introduces 3 alerts when merging e90627298cdc9e60df119d0ec4643cf85202c967 into 239552b - view on LGTM.com

new alerts:

  • 3 for Unused local variable

@LefterisJP LefterisJP merged commit 45cc47f into rotki:develop Oct 19, 2020
@LefterisJP LefterisJP deleted the aave_graph branch October 19, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize The graph subgraph for aave history too
1 participant