-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Windows TBB path logic fails if BridgeStan is not yet downloaded #149
Conversation
I'd like to publish a 2.1.1 shortly after this, assuming nothing new comes in |
Seems I can't easily test this PR directly in the nutpie CI, because checking out stan fails with a "path too long" error... But this looks good to me, assuming tests pass. |
Oh man, I recently dealt with this for Facebook's prophet package. Pip seems to like really long base path names, and a lot of the bash-on-Windows tools (including git, but also things like You may be able to get things going by setting |
@roualdes thoughts on this fix and a .1 release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, this all seems reasonable to me. Is it possible for @aseyboldt to test this once it is accepted, but before we do a .1 release?
This does indeed fix the issue. |
Calling the setup function manually seems like a reasonable requirement for users who intend to load the dll not using the Python class we provide |
Closes #148
This also adds a very trivial test: Can the package be imported without
BRIDGESTAN
being set ahead of time.