Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Stan 2.33 #167

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Update to Stan 2.33 #167

merged 5 commits into from
Sep 6, 2023

Conversation

WardBrian
Copy link
Collaborator

Closes #154 and #127

  • Updates submodule and stanc versions
  • Uses new feature unconstrain_array to simplify param_unconstrain
  • Documents new compile flag STAN_MATH_CONSTRAINT_TOLERANCE

@WardBrian WardBrian linked an issue Sep 6, 2023 that may be closed by this pull request
Runtime errors during param_unconstrain because of precision issues #127
Closed
roualdes
roualdes approved these changes Sep 6, 2023
View reviewed changes
Copy link
Owner

@roualdes roualdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That's a great simplification of bs_model::param_unconstrain. Thanks.

@WardBrian WardBrian merged commit a0ce2ce into main Sep 6, 2023
19 checks passed
@WardBrian WardBrian deleted the feature/stan-2-33 branch September 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roualdes roualdes roualdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@WardBrian @roualdes