Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML not being detected as XML because of "<html" #1031

Merged
merged 2 commits into from
May 30, 2019
Merged

Fix XML not being detected as XML because of "<html" #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
944f9ae
Fix XML not being detected as XML because of "<html"
miparnisari Nov 12, 2018
788a3e4
Simplify XML test
miparnisari May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rouge/lexers/html.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class HTML < RegexLexer

def self.detect?(text)
return true if text.doctype?(/\bhtml\b/i)
return false if text =~ /\A<\?xml\b/
return true if text =~ /<\s*html\b/
end

Expand Down
1 change: 1 addition & 0 deletions spec/lexers/xml_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
it 'guesses by source' do
assert_guess :source => '<?xml version="1.0" encoding="utf-8"?>'
assert_guess :source => %{#{bom}<?xml version="1.0" encoding="utf-8"?>}
assert_guess :source => '<?xml version="1.0" ?><html destdir="${reportfolderPath}" encoding="utf-8" />'
assert_guess :source => '<!DOCTYPE xml>'
deny_guess :source => '<!DOCTYPE html>'
end
Expand Down