shell lexer: add Alpine Linux APKBUILD (simple two line patch) #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is not related to the patch. @dblessing: it would be great if you could take a look at this simple two line change. The feature has >20 upvotes in the gitlab-ce issue tracker. |
ollieparanoid
changed the title
|
FWIW, I'm still highly invested in getting this merged. Thank you in advance to whoever steps up to maintain rouge in the future, and is reading this. Your work is appreciated very much. |
|
@ollieparanoid Sorry it's taken a while to get back to you on this :( Can you do a force push and kick off a new CI testing cycle now that we've got that fixed? Something like: $ git commit --amend
$ git push --forceshould work. |
pyrmont
added
the
author-action
Properly highlight Alpine's package build recipes. Done in the same way as 5dca906 for Arch Linux.
ollieparanoid
force-pushed
the
apkbuild-shell-lexer
branch
from
921726e
to
9176a51
Compare
|
@pyrmont: sure, done! Happy to see activity here :) |
pyrmont
removed
the
author-action
|
No worries :) Still discussing with the other maintainers when to release a new build of the gem but hopefully it'll be soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly highlight Alpine's package build recipes. Done in the same way as 5dca906 for Arch Linux.
Downstream feature request:
https://gitlab.com/gitlab-org/gitlab-ce/issues/56579