remove bundler from the Gemfile #1110
Conversation
mojavelinux
commented
May 14, 2019
•
mojavelinux
commented
- bundler doesn't belong in the Gemfile
- fixes builds
- downgrade dependencies for unsupported Ruby versions
mojavelinux
force-pushed
the
fix-build
branch
2 times, most recently
from
1f988ef
to
584bab6
Compare
- bundler doesn't belong in the Gemfile - fixes builds - downgrade dependencies for unsupported Ruby versions
|
With this PR, the existing CI builds now pass. I think this is extremely important to get merged asap as it will allow other PRs to be reviewed more easily. Could you have a quick look @jneen? If you don't have time right now, is there someone else you could delegate it to? Thanks! |
|
Prior attempt at resolving CI builds: #1062 |
|
This PR addresses several other outstanding issues without changing any other policy. So technically it could be merged without discussion. |
|
Is there anything we can do to move this forward? I think it's the baseline to begin to free up the other PRs. |
|
@mojavelinux I'm not affiliated with this project at all. But out of curiosity, may I ask what those "several other outstanding issues" are and how using |
|
Simply put, the build runs to completion so we can see if it's the incoming changes causing the build to fail. There are 128 open PRs. No PR can be merged if the build is failing. https://github.com/jneen/rouge/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc To clarify, we're not using parallel just for outdated Rubies. We're downgrading the version of parallel for outdated Rubies because parallel doesn't support them anymore in the latest version. |
|
(Whether to remove the outdated Rubies is a separate discussion that shouldn't have to hold up fixing the build). |
|
I do not work on this project anymore. Please ping @dblessing and @gfx. |
Ah I see. |
This commit is intended to be compatible with rouge-ruby#1110 (ie. it can be applied after that PR). It removes older Rubies from those tested by Travis and removes cruft from Gemfile that is no longer needed once older Rubies are dropped.
|
@dblessing @gfx I'm still keen on getting this merged so we can get the build back to green. I think that's a first step in getting this project back on its feet. |
|
🍾 🍻 🎉 |
|
Woohoo! The first commit since months... 🎉 |
