Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim Lexer: Fix multiline ruby code #1130

Merged
merged 2 commits into from
May 28, 2019
Merged

Slim Lexer: Fix multiline ruby code #1130

merged 2 commits into from
May 28, 2019

Conversation

reneklacan
Copy link
Contributor

This change fixes lexing of multiline string using \ at the end of the line.

Example:

= render( \
    partial: 'foo',
    locals: { \
      foo: :bar,
    },
  )

This change fixes lexing of multiline string using `\` at the end of the line.

Example:

```
= render( \
    partial: 'foo',
    locals: { \
      foo: :bar,
    },
  )
```
@pyrmont
Copy link
Contributor

pyrmont commented May 28, 2019

@reneklacan The visual samples are located in spec/visual/samples. The Slim one is at spec/visual/samples/slim. If you could put an example in there as well, that'd be great.

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label May 28, 2019
@reneklacan
Copy link
Contributor Author

@pyrmont Thanks. Done!

@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed author-action The PR has been reviewed but action by the author is needed labels May 28, 2019
@pyrmont pyrmont merged commit 23755bc into rouge-ruby:master May 28, 2019
@pyrmont
Copy link
Contributor

pyrmont commented May 28, 2019

@reneklacan Thanks!

@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants