Fix debug errors in Liquid lexer #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Liquid lexer used `nil` to avoid creating tokens for unwanted capture groups. When run with `@debug` enabled, this would cause Sinatra to crash. This commit removes the need for passing `nil` by using non-capturing groups.
|
This fixes the problem with the Liquid lexer that was observed in #943. The fix in that PR involved patching |
ashmaroli
reviewed
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Liquid lexer used
nilto avoid creating tokens for unwanted capture groups. When run with@debugenabled, this would cause Sinatra to crash. This commit removes the need for passingnilby using non-capturing groups.