Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting of keyword defined? in Ruby #1247

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Fix highlighting of keyword defined? in Ruby #1247

merged 3 commits into from
Jul 8, 2019

Conversation

ashmaroli
Copy link
Contributor

Resolves #1241

Before

image

After

image

pyrmont
pyrmont reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I've misunderstood how word boundaries work in regular expressions.

lib/rouge/lexers/ruby.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label Jul 3, 2019
@pyrmont pyrmont merged commit 23ae3ea into rouge-ruby:master Jul 8, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 8, 2019
@ashmaroli ashmaroli deleted the highlight-ruby-defined-kw branch July 8, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby lexer does not detect defined? as a keyword for parenthesized argument
2 participants
@ashmaroli @pyrmont