Add lexer for Cython support #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
suggested changes
Jul 29, 2019
pyrmont
added
author-action
… of new array, and made more specific whitespace rules
pyrmont
added
needs-review
pyrmont
added
author-action
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Gitlab uses this lexer, I wanted to implement cython support. However, this is pretty much the first code I've written in Ruby.
I lent heavily on the Pygments implementation (https://bitbucket.org/birkenfeld/pygments-main/src/0bcf355df9fbe55d3753256c01260f48fa01e794/pygments/lexers/python.py?at=default&fileviewer=file-view-default#python.py-570) as suggested in the issue #1101
From what I can tell it passes tests, and a look at the rackup output seems to produce the right results for highlighting on the test file I used.
Let me know if this works and what needs to change.