-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nesasm lexer #1354
Added nesasm lexer #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the the PR! I've made some changes and tried to explain them here with comments. Please let me know if I've inadvertently broken anything or if anything doesn't make sense!
Thanks for your time cleaning up and improving my code. It's all working great. |
@ShyDev Oh, please push them to your fork. The PR is synced with it so anything you push there will show up here. I've got commit rights to that fork so the changes I've made here have actually been to your fork; make sure you pull them down with |
As for the right token, it's usually more of an art than a science. |
@ShyDev Thanks for submitting the lexer—it all looks good to me! This will be part of v3.14.0 when it comes out on 10 December 🎉 |
6502 assembler geared towards NES
http://nespowerpak.com/nesasm/
Never even saw ruby code before, never done pull requests.
Hopefully I did not screw up completely