Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeFEM lexer (inherited from C++) #1356

Merged
merged 7 commits into from
Dec 18, 2019
Merged

Conversation

sgarnotel
Copy link
Contributor

Lexer for FreeFEM, following the recommandations of PR #1020

@sgarnotel sgarnotel mentioned this pull request Nov 8, 2019
@pyrmont pyrmont self-assigned this Nov 8, 2019
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Nov 8, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Dec 18, 2019

@sgarnotel Sorry, this took a lot longer to get to than I originally intended! I've made some minor (mostly stylistic changes). Let me know what you think!

@sgarnotel
Copy link
Contributor Author

@pyrmont It is ok for me.
On the other hand, in the demo, I wanted to test the ' operator, but it is not such important.
Thanks

@pyrmont
Copy link
Contributor

pyrmont commented Dec 18, 2019

@sgarnotel The demo is really just to make sure that the lexer loads. It's not really intended to be used for testing of the lexing of particular constructs.

If you want to do that, you can either add the construct to your visual spec and then check it visually or you can add it to the test file for the particular lexer. You can see an example of how that would work in the recent PR for the Console lexer.

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Dec 18, 2019
@sgarnotel
Copy link
Contributor Author

@pyrmont Ok, so all is ok for me

@pyrmont
Copy link
Contributor

pyrmont commented Dec 18, 2019

Cool. I'll merge this now and it'll be in the next release of Rouge coming 14 January.

@pyrmont pyrmont merged commit 2caa1a0 into rouge-ruby:master Dec 18, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants