Add support for nullish coalescing operator to TypeScript lexer #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is dependent on #1530 and will need to be rebased once that is merged. |
pyrmont
added
dependent-pr
pyrmont
force-pushed
the
bugfix.typescript-nullish-coalescing
branch
from
15fab46
to
437bcb7
Compare
pyrmont
added
needs-review
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
) TypeScript has added support for the nullish coalescing operator `??` as of version 3.7. This commit adds support by prepending a rule to the `:root` state of lexers that extend the TypeScript common module. When JavaScript adopts the operator, the rule should be moved into the `:root` state of the JavaScript lexer and removed from the TypeScript common module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming ECMAScript feature is the nullish coalescing operator,
??. While it is not part of ECMAScript yet, it is supported in TypeScript. However, the current TypeScript lexer breaks when lexing it in template strings. This PR fixes this by adding a rule to match against this operator.This fixes #1516.