Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a :content option to http #1592

Merged
merged 1 commit into from
Sep 25, 2020
Merged

add a :content option to http #1592

merged 1 commit into from
Sep 25, 2020

Conversation

jneen
Copy link
Member

@jneen jneen commented Sep 25, 2020 •
edited
Loading

This allows overriding of the auto-detected lexer for the content, resolving this comment: #1028 (comment)

``` http?content=jsonc
HTTP/1.1 200 OK
Content-Type: application/json

{
  // Now this comment will be supported!
  "foo": "bar"
}
```

add a :content option to http
854a5df 
this allows overriding of the auto-detected lexer for the content.
@jneen jneen mentioned this pull request Sep 25, 2020
Closed
asbjornu
asbjornu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ❤️

@jneen jneen merged commit 86ca47d into master Sep 25, 2020
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@jneen @mattt
add a :content option to http (rouge-ruby#1592)
4f0c17c 
this allows overriding of the auto-detected lexer for the content.

Co-authored-by: http://jneen.net/ <jneen@jneen.net>
@tancnle tancnle deleted the feature.http-content-lexer branch September 22, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneen @asbjornu