Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string interpolation in Ruby percent literal #1945

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Apr 30, 2023

This PR fixes string interpolation in Ruby's percent literal %.

Before After
before after

Closes #1944

@tancnle
Copy link
Collaborator Author

tancnle commented Apr 30, 2023

👋🏼 @ltickett Would it be possible if you could confirm this will fix the reported issue? 🙏🏼

@ltickett
Copy link

It certainly looks like it @tancnle

Before:

image

After:

image

Thanks so much 🙏

@tancnle tancnle added this pull request to the merge queue Apr 30, 2023
Merged via the queue into rouge-ruby:master with commit aa1a124 Apr 30, 2023
@tancnle tancnle deleted the fix.ruby-shorthand-string-inter branch April 30, 2023 23:59
@ltickett
Copy link

ltickett commented May 1, 2023

Thanks again for fixing this @tancnle

What's the release process/cadence for the project please?

@tancnle
Copy link
Collaborator Author

tancnle commented May 8, 2023

Sorry for the delay @ltickett. I will try to cut a release before the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with shorthand ruby string interpolation
2 participants