Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lexer for P4 #2049

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Add lexer for P4 #2049

merged 3 commits into from
Jul 4, 2024

Conversation

rcgoodfellow
Copy link
Contributor

This PR adds support for the P4 language.

There has been a bit of discussion and use of this lexer in the P4 community here: p4lang/p4-spec#1115 (comment).

@jafingerhut
Copy link

I have been using this for a couple of weeks now to good effect in an AsciiDoc version of the P4 language specification. I have already given the submitter comments earlier, which he has incorporated into this PR, so it looks good to me.

@rcgoodfellow
Copy link
Contributor Author

@tancnle any chance we can work toward getting this in the next release?

@tancnle tancnle self-requested a review July 3, 2024 06:14
@tancnle tancnle added the needs-review The PR needs to be reviewed label Jul 3, 2024
@tancnle
Copy link
Collaborator

tancnle commented Jul 4, 2024

Thank you for your work on this PR @rcgoodfellow. LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Jul 4, 2024
Merged via the queue into rouge-ruby:master with commit 93e2bae Jul 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants