-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature.robot #611
Feature.robot #611
Conversation
@jneen , Thank you for the review. I've removed all unused code. |
Hi, any updates on this PR? Is there a way to help moving this forward? Thanks |
To my eye this could be merged to trunk but it is up to manintainers to do. Anyway with my branch I successfully patched my gitlab setup and it works of a year now. (Have to repatch on every major upgrade though). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments are taken into account
Our team (using Gitlab) is starting to embrace Robot Framework. For a "replacement" of Pygments, this is a bit of a sore spot. 👊 |
How's progress with this PR? |
@falxcerebri I'm sorry you've been waiting so long :( I joined the maintainer's group a couple of months back and had been working my way through the outstanding PRs in reverse chronological order. Unfortunately, that means that the older PRs are having to wait even longer. That said, while I follow the above as a general rule, I move PRs to the front of the queue when there's some kind of activity (like this!). I've added this one now and will be getting to it ASAP! |
Sorry not to have made more rapid progress on this. I've force pushed a rebased version that makes development a bit easier (once you've installed the gems, you can run tests with @iakovgan said it was his first lexer and unfortunately (although very understandably!) it looks to me like it requires a fair amount of rewriting to be more consistent with the way Rouge's regular-expression-based lexers usually work. The difficulty (for me) is that the Robot framework is a DSL which means it's taking a bit of time for me to wrap my head around it. I'll try to move it forward as quickly as I can but progress will probably be a bit slower than usual :( |
Just wanted to confirm I haven't forgotten about this: I'm afraid my progress has been slow but am still moving forward. |
That's great to hear! Fingers crossed! |
as it interferes with ipv4
94c5a53
to
9d692c7
Compare
It took a while but I've pushed a new version of the lexer. I'm sure there are edge cases where it doesn't lex things correctly but it generally seems to work as expected. I know that it doesn't tokenise tests correctly where a template is set in the Settings section but that looks like a pain to handle (not least because those templates can be unset per test) so I've left that for some unspecified point in the future. Let me know what you think, @falxcerebri. |
This feature provides syntax hilighting of Robot Framework DSL. http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html
Comments, review and feedback is welcome. This is my first lexer.
Thank you for the tool.
Regards,
Iakov