-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSL Lexer #871
Add JSL Lexer #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your submission. I'm trying to help triage pull requests. Just one minor nit, which I guess is down to the age of your pull request..
@justinc11 I'm sorry it's taken so long to get back to you on this one. I also apologise for force pushing to your branch: I had a few comments on your code but it's been so long since you submitted it that I felt bad asking you to make changes to something you might not remember that well any more. Hopefully all the changes are pretty straightforward. I've tried to make the lexing rules a little more robust based on a cursory reading of the JSL documentation. Please let me know if anything stands out as broken. |
Hi @pyrmont, thanks a bunch for cleaning this up for me (it needed some help). Since I initially opened this pull request I realized I forgot to account for date literals (shown here), but didn't get to it until your response reminded me. I also found out about a name-literal syntax similar to SAS' name literals (e.g. I pushed to a separate branch, date-name-literal, rules for the date and name literals (I didn't want to mess with your already reviewed code). Could you let me know if these look okay or if any changes are needed before merging into this pull request? |
@justinc11 Yep, that branch looks generally OK. Can you merge it in? |
Done. Thanks! |
@justinc11 Thanks for the submission! Sorry again that it took so long but we got there in the end. The next release of Rouge is scheduled for this coming Tuesday so this lexer will be included in version 3.10.0 🎉 |
This PR adds support for JSL, the scripting language used in JMP software.