Implement the Terraform Lexer #917
Conversation
| @heredocstr = Regexp.escape(m[5]) | ||
| push :heredoc | ||
| end | ||
| end |
There was a problem hiding this comment.
Any reason for putting these above the def self.* methods and also above the root state? While it's a minor style thing, it's customary to have root be the first state and methods to appear at the top before states. Maybe there's a specific thought you had in mind, though?
There was a problem hiding this comment.
Not quite, I just took the ordering found in the JavaScript lexer: https://github.com/jneen/rouge/blob/master/lib/rouge/lexers/javascript.rb. It kind of made sense since this set of keywords may be overridden in derived lexers (Terraform redefines these)
What do you recommend?
| token Name::Builtin | ||
| else | ||
| token Name::Other | ||
| end |
There was a problem hiding this comment.
Why are declarations/keywords/etc. tokenized here and in the root state of the hcl lexer? Can you give me an example of each case?
There was a problem hiding this comment.
expression is used inside interpolations.
resource "something" {
}
resource "other" {
key = "${resource.something.key}" # This is handled by the expression state.
}
dblessing
added
the
author-action
|
Awesome, thanks @dblessing! |
Fixes #722.
This implements two parts of the lexer, the HCL lexer implements most of the HCL language, and the Terraform lexer adds keywords and string interpolations.