Same increment for arc filling and path #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current calculation of radial increment is different for arc filling and drawing, making it very different in case of a low `curveStepCount` This change copies the increment calculation from drawing to filling for a better adjustment.
pshihn
reviewed
May 10, 2020
| @@ -201,7 +201,7 @@ export function patternFillArc(x: number, y: number, width: number, height: numb | |||
| strt = 0; | |||
| stp = Math.PI * 2; | |||
| } | |||
| const increment = (stp - strt) / o.curveStepCount; | |||
| const increment = Math.min(Math.PI / o.curveStepCount, (stp - strt) / 2); | |||
| const points: Point[] = []; | |||
There was a problem hiding this comment.
I'm not sure if this makes it better. Filling needs a higher resolution than stroking. In stroking you are connected sampled points with a curve. When filling, we are approximating it to a polygon so a greater number of points is actually useful.
Perhaps I'm missing something. Can you share a sample where this makes it better? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current calculation of radial increment is different for arc filling and drawing, making it very different in case of a low
curveStepCountThis change copies the increment calculation from drawing to filling for a better adjustment.