Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

specify FBSDKCoreKit version #128

Merged
merged 1 commit into from
May 27, 2019
Merged

specify FBSDKCoreKit version #128

merged 1 commit into from
May 27, 2019

Conversation

nodinosaur
Copy link
Contributor

FBSDKLoginKit was pulling the latest version of FBSDKCoreKit (transitive dependency issue)

@nodinosaur
specify FBSDKCoreKit version
c01db7d 
FBSDKLoginKit was pulling the latest version of FBSDKCoreKit (transitive dependency issue)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 141

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.06%) to 90.476%
Totals Coverage Status
Change from base Build 124: 1.06%
Covered Lines: 76
Relevant Lines: 84
💛 - Coveralls

@kevin-lot
Copy link

What's the best PR ?
Your or this one: #124.

PR124 update dependencies to 5.0.0.

@nodinosaur
Copy link
Contributor Author

I am impartial.
I am just pleased to see that the Core SDK version is also specified

@roughike roughike merged commit 8cb0cbb into roughike:master May 27, 2019
@roughike
Copy link
Owner

Thanks!

@roughike roughike mentioned this pull request May 27, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodinosaur @coveralls @kevin-lot @roughike