Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Invalid version string" Composer exception for dev-master plugins #4

Merged
merged 1 commit into from
Aug 3, 2014
Merged

Conversation

mazzanet
Copy link
Contributor

When using Composer to update plugins with a version constraint of dev-master, Composer errors out with:

[UnexpectedValueException]
Invalid version string "1.1-git"

The "-git" is already handled for the Roundcube version itself earlier in the same function:

    if (preg_match('/define\(.RCMAIL_VERSION.,\s*.([0-9.]+[a-z-]*)?/', $iniset, $m)) {
        $rcubeVersion = $parser->normalize(str_replace('-git', '.999', $m[1]));
    }

thomascube added a commit that referenced this pull request Aug 3, 2014
Fix "Invalid version string" Composer exception for dev-master plugins
@thomascube thomascube merged commit 671e117 into roundcube:master Aug 3, 2014
@mazzanet mazzanet deleted the patch-1 branch August 26, 2017 06:55
@mazzanet mazzanet restored the patch-1 branch August 26, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants