No notification buttons for sideloaded module

[pylerSM]

I am just playing with Xposed, developing small module and I have just realized that notification about new/updated sideloaded module (APK from exclipse) do not include notification buttons (Reboot and activate). There is no such buttons for sideloaded modules.

Can you add these buttons, please?

[GermainZ]

It only appears if you've enabled a module in the past. If you clear the emulator's data before every install, that'll be never.

[pylerSM]

Yes, but atleast Reboot button should be there.

[rovo89]

Do you mean newly installed or updated modules?

The buttons to reboot after updating an already activated module should always be shown. If not, you probably haven't expanded the notification. I think only the top notification is expanded by default, and I think that's fine.

For newly installed modules, it indeed depends on whether you have at least one active module. If not, activating your first module via notification might not leave you in doubt where you can deactivate the module later. That's why "reboot & activate" isn't shown, so you have to go to the module section (e.g. by clicking on the notification). Showing a "reboot" button instead doesn't make sense to me, because it would mean you restart without activating the module.

[theknut]

I don't understand. I always deploy apk with Android Studio and then use
the notification buttons the reboot.

But as GermainZ said, if you never enabled a module before the buttons are
not added. The intention is the get new users to know where modules can be
activated. If it wouldn't be like this there might be a user who doesn't
know how to disable a module is he wants to.
Am 13.06.2014 20:22 schrieb "pyler" notifications@github.com:

Yes, but atleast Reboot button should be there.

—
Reply to this email directly or view it on GitHub
#201 (comment)
.

[theknut]

Ninja'd...
Am 13.06.2014 21:33 schrieb "Alexander Schulz" <
alexander.as.schulz@gmail.com>:

I don't understand. I always deploy apk with Android Studio and then use
the notification buttons the reboot.

But as GermainZ said, if you never enabled a module before the buttons are
not added. The intention is the get new users to know where modules can be
activated. If it wouldn't be like this there might be a user who doesn't
know how to disable a module is he wants to.
Am 13.06.2014 20:22 schrieb "pyler" notifications@github.com:

Yes, but atleast Reboot button should be there.

—
Reply to this email directly or view it on GitHub
#201 (comment)
.

[pylerSM]

^this. i havent enabled other modules. Solved & closed.

[pylerSM]

Last time I have this issue also. Sometimes it is expanded, sometimes not. Probably controlled by Android but anyway, I don't like this behaviour.

In showModulesUpdatedNotification() we do not create expanded notification (NotificationCompat.BigTextStyle()) just like in showNotActivatedNotification.

@rovo89 could we rework it to expanded notification just like you did it in showNotActivatedNotification?

[rovo89]

Sorry, no idea what you mean. BigTextStyle just means that we can use different texts for the expanded notification versus the collapsed notifcation. The buttons should be independent of that. Whether they are shown or not is indeed controlled by Android - only the top notification shows the buttons. I don't think we should interfere with that on app-level. If you don't like it, there might be an Xposed module which can always show them.

[pylerSM]

Yes, I understand.

there might be an Xposed module

Xposed yeah :)