Added ability to sign in with Passkey #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhamann
reviewed
Dec 7, 2022
| //Add passkey to the Rownd user | ||
| method = PasskeyCoordinatorMethods.SignUp | ||
| let anchor: ASPresentationAnchor = (getWindowScene()?.windows.last?.rootViewController?.view.window)! | ||
| let bottomSheetController = getWindowScene()?.windows.first?.rootViewController?.presentedViewController as! BottomSheetController |
There was a problem hiding this comment.
I wonder if we should just require this to be passed in as a function argument so we don't have to force typecast it, which could result in a crash.
There was a problem hiding this comment.
Updated. I added an internal bottomSheetController to the Rownd instance.
I also added guards for iOS versions under 15 for Passkey.
mhamann
reviewed
Dec 7, 2022
|
|
||
| let assertionRequest = publicKeyCredentialProvider.createCredentialAssertionRequest(challenge: challenge) | ||
|
|
||
| // Also allow the user to use a saved password, if they have one. |
There was a problem hiding this comment.
remove password request stuff
mhamann
reviewed
Dec 7, 2022
| // After the server verifies the userName and password, sign in the user. | ||
| // didFinishSignIn() | ||
| default: | ||
| fatalError("Received unknown authorization type.") |
There was a problem hiding this comment.
change to a log statement about unsupported authorization type
mhamann
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions to try out
Requirements to enable Passkey on iOS
To test with a dev App, you'll need to set the domain extension with
.dev.rownd.link