Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSV import): error while using a column as row id #1514

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

iamanishroy
Copy link
Member

@iamanishroy iamanishroy commented Dec 21, 2023

User's issue:
User have reported an issue with batch importing CSV files when selecting a custom column for Document IDs. Although importing the same CSV with auto-generated Document IDs works, choosing a specific column as Document IDs leads to an error: "n.charAt is not a function."

Cause:
Column types like reference and image, require custom parsers. Previously, these parsers were stored in an object with the column index as the key. However, when using a custom document ID, the explicit setting of the document ID resulted in a change to the column index reference.

Fix:
The fix involves using the column key as the key to store the parsers, rather than relying on the column index.

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 0:41am

Copy link

vercel bot commented Dec 21, 2023

@iamanishroy is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@shamsmosowi shamsmosowi merged commit 34e9769 into rowyio:develop Dec 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants