Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#598: implementation of HotKeys #612

Conversation

gibsonliketheguitar
Copy link
Contributor

@gibsonliketheguitar gibsonliketheguitar commented Dec 28, 2021

#598
Implement Hotkey as a Higher Order Component. An alternative route would be using making a custom hook.

In addition, I tried hooking up addRow but it's being buggy.
And in the future, we will have to decide

  1. create ref to call respective buttons/actions
  2. replicate the same ref style as AddColumn

I notice that there is already a useHotKey hook, as well as components.
What's going on there?

@gibsonliketheguitar gibsonliketheguitar marked this pull request as draft January 5, 2022 12:08
@shamsmosowi
Copy link
Member

useHotKey was used for copy/cut/paste shortcut, I think it was disabled during a RDG migration due to a breaking change, needs to be reimplemented, feel free to give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants