Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Richtext field full screen mode, similar to markdown fieldtype #972

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

saravanan-inc
Copy link
Contributor

#752
Based on this issue, added a plugin based on the @tinymce/tinymce-react react library
For more details on the plugin refer https://www.tiny.cloud/docs/plugins/opensource/fullscreen/

Added the fullscreen plugin in plugin array and toolbar
image
image

@vercel
Copy link

vercel bot commented Nov 23, 2022

@saravanan-inc is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rowy-os ❌ Failed (Inspect) Nov 24, 2022 at 8:32AM (UTC)

@shamsmosowi
Copy link
Member

Hi @saravanan-inc, are you able to run yarn build successfully? the perview deploy is currently failing

@saravanan-inc
Copy link
Contributor Author

@shamsmosowi yeah yarn build is working in wsl2 using Ubuntu and also in windows 11
image

src/components/RichTextEditor.tsx Outdated Show resolved Hide resolved
Co-authored-by: Sidney Alcantara <sidney@sidney.me>
@notsidney notsidney merged commit 15e1254 into rowyio:develop Nov 28, 2022
@saravanan-inc
Copy link
Contributor Author

@notsidney I checked your styles and the z-index of the modal is 1200 but we need 1203 to hide the sidebar and also as for the colour since it transparent background is visible
image

notsidney added a commit that referenced this pull request Nov 29, 2022
@notsidney
Copy link
Contributor

Thanks for pointing this out @saravanan-inc. The styles were correct, but they weren’t being applied because a more specific CSS selector from the 3rd-party component’s default styles was overriding our styles.

The side drawer’s z-index is theme.zIndex.drawer - 1 (1199) and the full screen rich text editor is theme.zIndex.modal (1300). (MUI z-index values) The transparent background was making the side drawer visible, but you could not interact with the side drawer.

@saravanan-inc saravanan-inc deleted the richTextFullScreen_752 branch November 29, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants