Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Fix #29 add jobid checks #30

Closed
wants to merge 2 commits into from
Closed

Fix #29 add jobid checks #30

wants to merge 2 commits into from

Conversation

Shougo
Copy link
Collaborator

@Shougo Shougo commented Jun 21, 2018

@dylan-chong Please test it.

@Shougo
Copy link
Collaborator Author

Shougo commented Jun 21, 2018

@roxma Can you review/merge it?

Note: I have removed tabs.

@roxma
Copy link
Owner

roxma commented Jun 22, 2018

It looks like the errors in #29 are triggered when exit_cb is called before err_cb or out_cb.

"exit_cb": handler	Callback for when the job ends.  The arguments are the
                        ...
                        ...
			Note that data can be buffered, callbacks may still be
			called after the process ends.

vim-hug-neovim-rpc cleanup the job entry when exit_cb is called. It doesn't look like a good place to do the cleanup.

I'm wondering, is it better to cleanup the data in close_cb?

@roxma
Copy link
Owner

roxma commented Jun 22, 2018

If this PR is merged, we might lose data when exit_cb is called before data callbacks.

@roxma roxma mentioned this pull request Jun 22, 2018
@dylan-chong
Copy link

dylan-chong commented Jun 24, 2018

screen shot 2018-06-24 at 7 30 25 pm

After some research Macvim has some annoying problems being compiled with python for some reason.
In normal Vim, I don't get any problems on the current master or this branch.

Sorry if trying to fix this wasted some of your time

@Shougo
Copy link
Collaborator Author

Shougo commented Jun 24, 2018

Hm. It is related error?

Shougo/deoplete.nvim#782

@Shougo Shougo closed this Jun 24, 2018
@Shougo
Copy link
Collaborator Author

Shougo commented Jun 24, 2018

Closed. Because #31 is better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants