Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Overhaul #9

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

API Overhaul #9

wants to merge 34 commits into from

Conversation

roy-harmon
Copy link
Owner

@roy-harmon roy-harmon commented Mar 30, 2023

I'm switching communications over from an external database server to a REST API backed by an internal SQLite database. This includes a lot of minor improvements to the code base, too. The LIS still communicates with analyzers via serial ports and TCP sockets, but from now on, test orders will be sent to the LIS through the web API and stored in its internal database. Then the orders will be sent to the analyzer, the test will be run, the results will be stored in the internal database, and then those results will be available through the web API.

I'll be leaving this open while I add the rest of the endpoints (no pun intended) and workflow. At the moment, only GET requests to the /reports/patients, /reports/patients/{id}, and /requests/patients endpoints and POST, PUT, and DELETE requests to the /requests/patients endpoint are supported, but a lot of progress has been made recently and more will be added soon.

Next steps:

  • Add more endpoints (orders, results) with appropriate query parameters
  • Add PATCH support

In the meantime, feel free to leave any feedback here.

@roy-harmon roy-harmon added the enhancement New feature or request label Mar 30, 2023
@roy-harmon roy-harmon self-assigned this Mar 30, 2023
@roy-harmon
Copy link
Owner Author

I think this branch is almost ready to merge. It needs a bit more testing to ensure that the existing UniversaLIS functions still work with the new modifications, but once that's done, I think it's ready. Any additional improvements can be added separately.

@roy-harmon roy-harmon marked this pull request as ready for review April 16, 2023 07:25
@roy-harmon
Copy link
Owner Author

I've done a bit of an overhaul this week, moving the database management functions to the REST-LIS process and having UniversaLIS communicate with that process via the REST API to fetch pending requests and store result reports.
I've been struggling to configure a service installer package for the project, and since it's kept me stalled for months, I'm going to focus on getting the working executables into testing. That's the next step, and to that end, I'm going to post those files soon in the hopes that someone with a physical setup can help test the system.

@roy-harmon roy-harmon linked an issue Feb 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send to API and Test code mapping
1 participant