Fix error in parsing of hhea and vhea table and add sanity checks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'll double check it tonight if time permits and I'll try to release a new Nuget package if everything goes well. |
|
Both the hmtx and vmtx tables are based on glyph indexes. I think it would make sense to release a new version of the library once I get basic support for the glyf table up and running. |
|
After reading through the spec some more it seems the glyph index to character mapping in in the cmap table which you already implemented 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there were two mistakes. In both the hhea and vhea tables the 4 reserved int16 fields were seeked over by only seeking 4 bytes from the beginning of the file.