Add Chunk datastructure for more convenient access to getBlocks
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might hold off on merging this one until rollover to next semester. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-format patch
diff --git a/include/mcpp/util.h b/include/mcpp/util.h
index 5d9c21e..fa0c45d 100644
--- a/include/mcpp/util.h
+++ b/include/mcpp/util.h
@@ -129 +129 @@ struct Chunk {
-
+
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-format patch
diff --git a/include/mcpp/util.h b/include/mcpp/util.h
index 5f7a308..15caa86 100644
--- a/include/mcpp/util.h
+++ b/include/mcpp/util.h
@@ -129 +129 @@ struct Chunk {
-
+
Have any feedback or feature suggestions? Share it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make iterating and the general usability of
getBlocksa lot better.