field import: preserve generic info #53
Conversation
| CompilationUnit cu = run(genericColumnAccessor); | ||
|
|
||
| Assert.assertTrue(true); | ||
| //SymbolVisitorAdapterAssertions.assertTypeOfGenericConstant(cu); |
There was a problem hiding this comment.
Why are these lines of code commented? Could you add the appropriate assertions in each test case?
There was a problem hiding this comment.
These are the fluent assertions i wrote about via email. Useful but work in progress. Details in email.
There was a problem hiding this comment.
@cal101 can uncomment the code now?
|
OK, will take a look at the weekend. |
cal101
force-pushed
the
importfields
branch
2 times, most recently
from
4f2f148
to
60288cd
Compare
|
Found some rest of energy. Should be done. |
cal101
force-pushed
the
importfields
branch
2 times, most recently
from
401696d
to
599e6d4
Compare
|
Fixed merge conflict. Should be ready for merge now. |
| } | ||
| } | ||
| } | ||
| boolean isVisible = Modifier.isPublic(modifiers) |
There was a problem hiding this comment.
This code follows a different format than you suggested to me. Could you reformat the code?
|
Sorry. Will take a look at all pull requests when I am back. |
|
I see that formatting of the master is not clean, too but I also see that a reformatting changes things I intended to be left alone. |
|
reformatted and rebased on master. |
|
Rebased. |
|
Rebased again. |
|
Please tell if you have open issues. I consider it ready. |
|
Thanks @cal101 |
No description provided.