Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for Runner + Agent #13

Merged
merged 4 commits into from
Aug 16, 2018
Merged

Refactor for Runner + Agent #13

merged 4 commits into from
Aug 16, 2018

Conversation

rpau
Copy link
Owner

@rpau rpau commented Aug 16, 2018

It refactorizes the project to skip the test ignoring process
from the Test Runner execution, because it needs to rely into an
external agent. Otherwise, the test class has been already loaded and
can not be modified with the @ignore annotations.

Raquel Pau added 4 commits August 16, 2018 21:43
This patch refactorizes the project to skip the test ignoring process
from the Test Runner execution, because it needs to rely into an
external agent. Otherwise, the test class has been already loaded and
can not be modified with the @ignore annotations.
@rpau rpau changed the title Refactor for Runner + Listener Refactor for Runner + Agennt Aug 16, 2018
@rpau rpau changed the title Refactor for Runner + Agennt Refactor for Runner + Agent Aug 16, 2018
@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #13 into master will decrease coverage by 2.2%.
The diff coverage is 67.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
- Coverage     71.24%   69.03%   -2.21%     
+ Complexity      138      137       -1     
============================================
  Files            16       17       +1     
  Lines           546      562      +16     
  Branches         52       54       +2     
============================================
- Hits            389      388       -1     
- Misses          124      138      +14     
- Partials         33       36       +3
Impacted Files Coverage Δ Complexity Δ
...it4git/core/reports/AbstractTestReportStorage.java 77.27% <ø> (ø) 6 <0> (ø) ⬇️
...unit4git/core/bytecode/TestIgnorerTransformer.java 29.41% <0%> (+29.41%) 2 <0> (+2) ⬆️
...ain/scala/org/scalatest/junit/ScalaGitRunner.scala 0% <0%> (ø) 0 <0> (ø) ⬇️
.../org/walkmod/junit4git/junit4/Junit4GitRunner.java 85% <100%> (ø) 6 <0> (ø) ⬇️
...g/walkmod/junit4git/core/reports/ReportStatus.java 100% <100%> (ø) 1 <1> (?)
...rg/walkmod/junit4git/junit4/Junit4GitListener.java 84.61% <100%> (-15.39%) 4 <1> (ø)
.../org/walkmod/junit4git/core/TestsReportServer.java 63.82% <66.66%> (-10.53%) 9 <7> (ø)
...d/junit4git/core/reports/GitTestReportStorage.java 79.84% <66.66%> (-3.75%) 30 <0> (-1)
...rg/walkmod/junit4git/javassist/JavassistUtils.java 76.56% <66.66%> (-0.37%) 14 <0> (-1)
.../org/walkmod/junit4git/core/TestsReportClient.java 80% <66.66%> (-8%) 6 <4> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969266e...7d6d853. Read the comment docs.

@rpau rpau merged commit 1b49a02 into master Aug 16, 2018
@rpau rpau deleted the rpau-refactor-server branch August 16, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant