rsx: Epic fixes #4312

kd-11 · 2018-03-21T12:48:31Z

Partially fixes the common unreal engine 3 bugs #4025

Support for srgb (gamma corrected) texture data. Only DXT and ARGB8 are supported right now
Support for shadowmaps when used in wierd ways. Unreal reads all the components of a shadow comparison which is interesting
Crude support for arbitrary component shuffling on rendertarget resources. Very likely to be unused by any games and needs further polishing
A fix for AMD polaris and newer when using strict mode. Fixes exploding vertices

Extended commits

Reimplement TEX class of opcodes in FP
Implement SRGB framebuffer output
Reimplement framebuffer sampling and correctly implement color shuffling
Implement video-out calibration (ogl only)

The extended set fixes regressions introduced by the first set of patches

kd-11 · 2018-03-21T12:56:42Z

There are some regressions here, due to incorrect colorspace detection for some games (skate3 for example). I'm working on that and will push a fix before merging this.

Asinin3 · 2018-03-21T13:32:13Z

Before/After Comparisons (Click to Expand)

Dollar Dash Trial

Supersonic Acrobatic Rocket-Powered Battle-Cars

CellFactor: Psychokinetic Wars

Shadows of the Damned

Life is Strange

Mass Effect

Mass Effect 3

Final Exam

Mirrors Edge

Need for Speed: Most Wanted

Drakengard 3

Infamous Festival of Blood

Tony Hawk's Pro Skater HD

Papo & Yo

Destroy All Humans

Journey

Anna

MLB 09 The Show

Midnight Club: LA

Project DIVA

https://cdn.knightlab.com/libs/juxtapose/latest/embed/index.html?uid=96868b9a-2d37-11e8-b263-0edaf8f81e27

NIER

Asura's Wrath

Batman Arkham City

Ratchet & Clank

Ratchet & Clank 2

Ratchet & Clank 3

Army of Two

Army of Two 40th Day

Yakuza 3

Yakuza 4

Silent Hill: Downpour

Ride to Hell Retribution

New Comparisons with newer commit:

Uncharted

Gran Turismo HD Concept

Xcedf · 2018-03-21T17:17:49Z

The most pleasant part Issue #3031 is affected

Asinin3 · 2018-03-21T17:34:23Z

@Xcedf Actually Dante's Inferno kinda regressed: https://cdn.discordapp.com/attachments/345204501831221249/426056393527787526/unknown.png
https://cdn.discordapp.com/attachments/272035812277878785/426038632009302031/unknown.png
https://cdn.discordapp.com/attachments/345204501831221249/426064101526077450/2018-03-22_03-35-45.mp4

Edit: Fixed in new commits

Xcedf · 2018-03-21T17:39:53Z

@Asinin3 yeah, but i think it regressed by some other pr not this one, i remember someone wrote a few days ago that game became darker, and since i like this game i'm gonna investigate

Xcedf · 2018-03-21T17:50:18Z

@Asinin3 will try to build combined version later

Assassin's Creed normal colors

Lolipop ChainSaw now with shadows

jjsat · 2018-03-21T18:13:38Z

~~Dead Space Dismemberment Demo has a regression: it fails to compile a shader. Easy to reproduce because it happens right at startup.~~

E {rsx::thread} RSX: Failed to compile shader: Fragment shader failed to compile with the following errors:
ERROR: 0:56: error(#202) No matching overloaded function found: textureProj
ERROR: 0:56: error(#216) Vector field selection out of range "xyz"
ERROR: error(#273) 2 compilation errors.  No code generated


F {rsx::thread} class gl::glsl::link_exception thrown: linkage failed: 'Fragment shader(s) were not successfully compiled before glLinkProgram() was called.  Link failed.

~~The shader: FragmentProgram80.zip~~

Edit: Scrap that. I was on your rsx_volatile branch, not on master. Sorry.

MarioSonic2987 · 2018-03-21T18:29:25Z

GTA V is improved (Trevor's outfit is no longer red in this camera position) and regressed at the same time (water can is brown and lighting is dark).

Before:

After:

Edit: Returns to the same situation as in before screenshot.

Xcedf · 2018-03-21T18:29:45Z

Yakuza 3 now with shadows

Psycho-A · 2018-03-21T22:15:07Z

This fixed Silent Hill: Downpour, but bump-maps on characters and some itmes seems still to be rendered weird way, and dynamic shadows are glitchy if any resolution scaling different from 720p is chosen.

Dreadmoth · 2018-03-21T22:19:31Z

Red Dead Redemption regression

Master:

PR:

Guess this is due to the known incorrect colorspace detection issue? Occurs with Strict Rendering Mode enabled too.

Zangetsu38 · 2018-03-21T22:51:25Z

also problem on Format, on VK and OGL, regression it is broken again on X16 and 2 other
DX12
VK
OGL

Xcedf · 2018-03-22T05:37:26Z

Dante's Inferno regressed with very first commit c33f095
removing lines from VKTextureCache.h fixes this for me

if (colorspace != rsx::texture_colorspace::rgb_linear)
	vk_format = get_compatible_srgb_format(vk_format);

same for OGL, but of course it breaks the main gamma fix
As for RDR it regressed from a420e2e

kd-11 · 2018-03-22T12:19:35Z

The scope of this has grown significantly following further investigation. Relegated to WIP status until the supporting patches are ready.

Psycho-A · 2018-03-23T13:07:55Z

What about this issue - #3656
Is this a typical Unreal 3 games bug too?

Anty0 · 2018-03-23T16:02:26Z

You've got typo in includes. In commit "video out: Set up video configuration options in fxm".
It isn't "Emu/idManager.h" but Emu/IdManager.h". (I vs i)

Can't build on Linux without this fix, as Linux is case sensitive...

Psycho-A · 2018-03-24T00:57:33Z

After Extended commits, some interface elements of SH: Downpour got abnormally dark.

Before:

After:

Before:

After:

ActualMandM · 2018-03-24T05:39:09Z

Supersonic Acrobatic Battle-Cars' lighting has become more accurate with the latest changes.

guofuchou · 2018-03-24T11:12:49Z

how to download it

- Implement SRGB (gamma corrected) textures (DXT1, DXT3, DXT5, RGBA8 only) - Fix channel map decode for XY data texture formats - Fix remap layout for X16 textures (verified with Mass Effect 3)

- Export some debug information in the free texture register space components zw Very useful when analysing renderdoc captures - Enable shadow comparison on depth as long as compare function is active and texture is uploaded for depth read Some engines (UE3) read all the components in the shader and use mul/mad with the result

The restart emulation is there to keep the proprietary drivers from randomly crashing when using primitive restart

- TODO: Actually do something with the values

- Separate TXB from TXL: They are completely different! - Properly perform TMU emulation in the fragment shader. Implemens SRGB conversion and alphakill at the moment - Properly perform ROP emulation in the fragment shader. Implements FRAMEBUFFER_SRGB. While support on the chip looks to be incomplete (and wierd), it does work - Document some more bits in SHADER_CONTROL register

- Seems to be of limited use but if it is determined to be useful, a vulkan implementation can be done

- Reimplements render target views used for sampling - Optimizes access using an encoded control token - Adds proper encoding for 24-bit textures (DRGB8 -> ORGB/OBGR) - Adds proper encoding for ABGR textures (ABGR8 -> ARGB8) - Silence some compiler warnings as well - TODO: Real texture views for OGL current method is a hack

…che. - glEnable/glDisable should not be used with GL_BLEND as the main renderer uses the indexed variant

- GL queries share the target binding (not asynchronous!) - Discard active queries by closing them, leave closed queries alone (nothing to be done for discard op)

- gl/vk: Properly handle remapping temporary resources

woj1993 · 2018-03-24T13:38:32Z

@guofuchou Go to Commits. Click on tick on the last one. Chose Appveyor details, artifact and chose file.

Psycho-A · 2018-03-24T19:24:23Z

gl: Implement video-out calibration for gamma and dynamic range

Where can I find it? It's an user-defined feature, or just something internal?

whjhs1010203 · 2018-03-25T09:36:37Z

@Psycho-A
From System.h see that.
It's default I guess, so do NOT something.

kd-11 · 2018-03-25T10:30:49Z

Its enabled for gamma correction, but that doesnt seem to have much effect. Limited RGB does have a big effect but it simulates the washed out visuals you get on standard TV display and isnt visually pleasing imo It does add some implicit brightness to the games though - can be edited in config.yml
As for downpour getting darker menus, that will have to be investigated separately as the detection code was scrapped and now the game's texture settings are just blindly implemented in the fragment shaders with no special code or hacks. Probably caused by one setting implicitly overriding another.

Yuuyatails · 2018-03-25T23:56:41Z

This pull request has caused a potentially game-breaking graphical regression on Kamen Rider: Battride War Genesis, as after the game publishers logo screens and the loading screen, all the game shows most of the time were black screens with music running.

kd-11 mentioned this pull request Mar 21, 2018

Unreal Engine 3 games issues (common) #4025

Closed

This was referenced Mar 21, 2018

Shadows of the Damned [BLUS30653] - image still red with Strict Rendering Mode enabled. #4168

Closed

Shadows of the damned[blus30653] wrong rendered objects+performance slowdown #4288

Closed

AniLeo added the RSX label Mar 21, 2018

kd-11 changed the title ~~rsx: Minor fixes~~ [WIP] rsx: Minor fixes Mar 22, 2018

Asinin3 mentioned this pull request Mar 22, 2018

rsx: Typo fix #4311

Merged

kd-11 force-pushed the master branch from f34dd03 to 3ea4fc3 Compare March 23, 2018 16:32

kd-11 changed the title ~~[WIP] rsx: Minor fixes~~ [WIP] rsx: Epic fixes Mar 23, 2018

kd-11 force-pushed the master branch from 3ea4fc3 to 65ed168 Compare March 23, 2018 17:06

kd-11 added 2 commits March 24, 2018 14:18

rsx: Texture format fixes

68027f4

- Implement SRGB (gamma corrected) textures (DXT1, DXT3, DXT5, RGBA8 only) - Fix channel map decode for XY data texture formats - Fix remap layout for X16 textures (verified with Mass Effect 3)

kd-11 added 9 commits March 24, 2018 14:18

rsx/gl/vk: Obey channel remapping on framebuffer resources if requested

e720aed

vk: Fix AMD primitive restart emulation when strict mode is active

d134291

The restart emulation is there to keep the proprietary drivers from randomly crashing when using primitive restart

video out: Set up video configuration options in fxm

a5e71e9

- TODO: Actually do something with the values

gl: Implement video-out calibration for gamma and dynamic range

e3d6acb

- Seems to be of limited use but if it is determined to be useful, a vulkan implementation can be done

gl: Always use indexed blend caps to avoid conflict with the state ca…

9386126

…che. - glEnable/glDisable should not be used with GL_BLEND as the main renderer uses the indexed variant

gl: Fix leaking occlusion queries

88162ca

- GL queries share the target binding (not asynchronous!) - Discard active queries by closing them, leave closed queries alone (nothing to be done for discard op)

rsx: Fix some texture cache problems

58b05a8

- gl/vk: Properly handle remapping temporary resources

kd-11 force-pushed the master branch from 65ed168 to 58b05a8 Compare March 24, 2018 11:19

kd-11 changed the title ~~[WIP] rsx: Epic fixes~~ rsx: Epic fixes Mar 25, 2018

Merge branch 'master' into master

90aa7d9

kd-11 merged commit 887ea43 into RPCS3:master Mar 25, 2018

This was referenced Mar 25, 2018

GL/Vulkan: Ratchet & Clank 1/2/3/Gladiator graphical issues #3846

Closed

GL/Vulkan: Midnight Club: Los Angeles #2825

Closed

GL/Vulkan: One Piece: Pirate Warriors graphical issues #2262

Open

GL/Vulkan: Skate 2 #2383

Closed

isshininu mentioned this pull request Mar 29, 2018

Silent Hill: Downpour [BLUS30565] - disappearing surface textures. #4358

Closed

k10kan mentioned this pull request Apr 22, 2019

[SOLVED] Working settings to enable resolution scaling in some (if not all) UE3 based games #5878

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rsx: Epic fixes #4312

rsx: Epic fixes #4312

kd-11 commented Mar 21, 2018 •

edited

kd-11 commented Mar 21, 2018

Asinin3 commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

Asinin3 commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

jjsat commented Mar 21, 2018 •

edited

MarioSonic2987 commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018

Psycho-A commented Mar 21, 2018 •

edited

Dreadmoth commented Mar 21, 2018

Zangetsu38 commented Mar 21, 2018 •

edited

Xcedf commented Mar 22, 2018 •

edited

kd-11 commented Mar 22, 2018 •

edited

Psycho-A commented Mar 23, 2018

Anty0 commented Mar 23, 2018

Psycho-A commented Mar 24, 2018 •

edited

ActualMandM commented Mar 24, 2018

guofuchou commented Mar 24, 2018

woj1993 commented Mar 24, 2018

Psycho-A commented Mar 24, 2018

whjhs1010203 commented Mar 25, 2018

kd-11 commented Mar 25, 2018

Yuuyatails commented Mar 25, 2018 •

edited

rsx: Epic fixes #4312

rsx: Epic fixes #4312

Conversation

kd-11 commented Mar 21, 2018 • edited

kd-11 commented Mar 21, 2018

Asinin3 commented Mar 21, 2018 • edited

Xcedf commented Mar 21, 2018 • edited

Asinin3 commented Mar 21, 2018 • edited

Xcedf commented Mar 21, 2018 • edited

Xcedf commented Mar 21, 2018 • edited

jjsat commented Mar 21, 2018 • edited

MarioSonic2987 commented Mar 21, 2018 • edited

Xcedf commented Mar 21, 2018

Psycho-A commented Mar 21, 2018 • edited

Dreadmoth commented Mar 21, 2018

Zangetsu38 commented Mar 21, 2018 • edited

Xcedf commented Mar 22, 2018 • edited

kd-11 commented Mar 22, 2018 • edited

Psycho-A commented Mar 23, 2018

Anty0 commented Mar 23, 2018

Psycho-A commented Mar 24, 2018 • edited

ActualMandM commented Mar 24, 2018

guofuchou commented Mar 24, 2018

woj1993 commented Mar 24, 2018

Psycho-A commented Mar 24, 2018

whjhs1010203 commented Mar 25, 2018

kd-11 commented Mar 25, 2018

Yuuyatails commented Mar 25, 2018 • edited

kd-11 commented Mar 21, 2018 •

edited

Asinin3 commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

Asinin3 commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

Xcedf commented Mar 21, 2018 •

edited

jjsat commented Mar 21, 2018 •

edited

MarioSonic2987 commented Mar 21, 2018 •

edited

Psycho-A commented Mar 21, 2018 •

edited

Zangetsu38 commented Mar 21, 2018 •

edited

Xcedf commented Mar 22, 2018 •

edited

kd-11 commented Mar 22, 2018 •

edited

Psycho-A commented Mar 24, 2018 •

edited

Yuuyatails commented Mar 25, 2018 •

edited