Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hexToRgbaCss when alpha is 0 #27

Merged
merged 4 commits into from
May 23, 2022
Merged

Fix hexToRgbaCss when alpha is 0 #27

merged 4 commits into from
May 23, 2022

Conversation

mgreystone
Copy link
Contributor

Fix hetToRgaCss when passing an explicit alpha of 0. Avoids a fasly trap that enoneously passes undefined to rgbaToRgbaCss.

@rpearce
Copy link
Owner

rpearce commented May 23, 2022

Thank you for this! Nice find.

@rpearce rpearce added the bug Something isn't working label May 23, 2022
@rpearce rpearce merged commit 7cd945b into rpearce:main May 23, 2022
@mgreystone mgreystone deleted the bugfix-hex-to-rgba-css branch May 23, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpearce rpearce rpearce approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgreystone @rpearce