Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a navbar for the scheduling coordinator. #40

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Conversation

lramos15
Copy link
Member

@lramos15 lramos15 commented Sep 5, 2018

This adds a navigation bar item for the scheduling coordinator. It seems to work pretty well, however it seems like the navbar gets stuck when the user logs out. I think it's because the logout process isn't completing correctly and is a side effect of the issue I have open that clicking home logs the user out. This fixes #35

Copy link
Member

@ddbruce ddbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'm confused about the logic change in index.html, so if you could explain that to me so I don't have to rack my brain, that'd be great. @lramos15

@lramos15
Copy link
Member Author

lramos15 commented Sep 5, 2018

Before nav bar items could be only listed as admin only and shows up for only admins. This allows nav bar items to be listed as scheduling only as well and only show for scheduling coordinator.

@ddbruce
Copy link
Member

ddbruce commented Sep 5, 2018

I understand the logic behind what you're trying to do, but I can't wrap my head around (!n.adminOnly && !isAdmin) || (!n.schedulingOnly && !isScheduling). Why does this work? I might not understand what the vars are, I guess.

@lramos15
Copy link
Member Author

lramos15 commented Sep 5, 2018

I believe it can also be written as (!n.adminOnly || isAdmin) || (!n.schedulingOnly || isScheduling) which might make it easier to wrap the brain around.

@lramos15
Copy link
Member Author

lramos15 commented Sep 6, 2018

@ddbruce you were correct the if statement logic was incorrect and is now much more.... logical.

@lramos15 lramos15 merged commit 070ec39 into master Sep 6, 2018
@MasterOdin MasterOdin deleted the Scheduling-navbar branch September 8, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling Coordinator does not have a navigation dropdown
2 participants