Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threshold option for max uncovered line count #168

Open
leth opened this issue Sep 10, 2018 · 0 comments · May be fixed by #173
Open

Threshold option for max uncovered line count #168

leth opened this issue Sep 10, 2018 · 0 comments · May be fixed by #173

Comments

@leth
Copy link

leth commented Sep 10, 2018 •
edited
Loading

It'd be really useful to be able to specify a threshold on uncovered line count, i.e. a maximum number of uncovered lines.

Why? In a codebase which continuously grows, if you fix the number of lines uncovered then you (loosely) enforce that all new code should be covered.

It's a neat trick which provides an automatic coverage ratchet, so long as the codebase keeps growing.
@leth leth changed the title Threshold option for (un)covered line count Threshold option for max uncovered line count Sep 10, 2018
guyfedwards added a commit to guyfedwards/flow-coverage-report that referenced this issue Oct 24, 2018
@guyfedwards
add threshold-uncovered option
0a79665 
allows threshold to be set by number of uncovered lines instead of percentage
of coverage.

In a codebase which continuously grows, if you fix the number of lines uncovered
then you (loosely) enforce that all new code should be covered.

closes rpl#168
guyfedwards added a commit to guyfedwards/flow-coverage-report that referenced this issue Nov 2, 2018
@guyfedwards
add threshold-uncovered option
5cca005 
allows threshold to be set by number of uncovered lines instead of percentage
of coverage.

In a codebase which continuously grows, if you fix the number of lines uncovered
then you (loosely) enforce that all new code should be covered.

closes rpl#168
@guyfedwards guyfedwards linked a pull request Nov 2, 2018 that will close this issue
Open
guyfedwards added a commit to guyfedwards/flow-coverage-report that referenced this issue Nov 2, 2018
@guyfedwards
add threshold-uncovered option
5c853d6 
allows threshold to be set by number of uncovered lines instead of percentage
of coverage.

In a codebase which continuously grows, if you fix the number of lines uncovered
then you (loosely) enforce that all new code should be covered.

closes rpl#168
guyfedwards added a commit to guyfedwards/flow-coverage-report that referenced this issue Nov 2, 2018
@guyfedwards
add threshold-uncovered option
ee62702 
allows threshold to be set by number of uncovered lines instead of percentage
of coverage.

In a codebase which continuously grows, if you fix the number of lines uncovered
then you (loosely) enforce that all new code should be covered.

closes rpl#168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add threshold-uncovered option guyfedwards/flow-coverage-report
1 participant
@leth