Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on the existence of the "Lead", and don't populate it #78

Closed
dralley opened this issue Jan 30, 2023 · 0 comments · Fixed by #101
Closed

Don't rely on the existence of the "Lead", and don't populate it #78

dralley opened this issue Jan 30, 2023 · 0 comments · Fixed by #101
Assignees
@dralley

Comments

@dralley
Copy link
Collaborator

dralley commented Jan 30, 2023

See rpm-software-management/rpm#2368
@dralley dralley self-assigned this Mar 9, 2023
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 9, 2023
@dralley
Remove "Lead" from the public API, stop reading/writing it
eedb0b3 
Lead has been deprecated upstream for a long time, and the upstream plan
is to stop populating the fields of the "Lead" apart from the magic
number, and simply fill out the remaining bytes in the structure with zeroes.

closes rpm-rs#78
@dralley dralley mentioned this issue Mar 9, 2023
Merged
3 tasks
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
b6bf731 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
fdb951b 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
d82078e 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
d5f1890 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
d4a1f2b 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
4a4fb1d 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 13, 2023
@dralley
Remove "Lead" from the public API
f590a53 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 19, 2023
@dralley
Remove "Lead" from the public API
b9ea5ef 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit to dralley/rpm-rs that referenced this issue Mar 19, 2023
@dralley
Remove "Lead" from the public API
4f26f3c 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes rpm-rs#78
dralley added a commit that referenced this issue Mar 19, 2023
@dralley
Remove "Lead" from the public API
64f1cb0 
It's been deprecated for a long time, the docs say the following: "All
the information contained in the lead has been duplicated or superseded by
information contained in the header." This has been true for more than
20 years now, so it's best to just ignore the Lead entirely. For
compatibility reasons it can't be dropped completely (yet).

closes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dralley dralley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "Lead" from the public API and stop checking its fields dralley/rpm-rs
1 participant
@dralley