Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take various updates from fez repository #1

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Take various updates from fez repository #1

merged 3 commits into from
Jul 20, 2022

Conversation

cmeister2
Copy link
Collaborator

@cmeister2 cmeister2 commented Jul 19, 2022 •
edited
Loading

Here's the updates from fez. I suggest we rename master to main as well.

I'd love it if my pet feature made it in (fast RPM reading) but I've not included in this MR.

fez was a fork of rpm-rs with a number of maintenance fixes. This
commit takes those maintenance fixes and ports them into rpm-rs

@cmeister2 cmeister2 requested a review from drahnr July 19, 2022 16:55
@cmeister2 cmeister2 mentioned this pull request Jul 19, 2022
Open
@Shinyzenith
Copy link
Member

Shinyzenith commented Jul 19, 2022 •
edited
Loading

PR looks good apart from the failing tests :D tysm cmeister!!

( Compiled locally rn - everything looks good )

@Shinyzenith Shinyzenith added the enhancement New feature or request label Jul 19, 2022
@cmeister2
Copy link
Collaborator Author

PR looks good apart from the failing tests :D tysm cmeister!!

( Compiled locally rn - everything looks good )

Ah, forgot to put back in [lib]name = rpm - readded.

Shinyzenith
Shinyzenith previously approved these changes Jul 19, 2022
View reviewed changes
@Shinyzenith
Copy link
Member

Also one minor nitpick: If the commit message could be a bit more descriptive it would help later on since not everyone knows about fez project

@cmeister2
Copy link
Collaborator Author

Also one minor nitpick: If the commit message could be a bit more descriptive it would help later on since not everyone knows about fez project

I've updated it with a little more detail.

Shinyzenith
Shinyzenith previously approved these changes Jul 19, 2022
View reviewed changes
drahnr
drahnr requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there is a stray TODO that should be moved to an issue and be referenced, otherwise LGTM!

@cmeister2
Take various updates from fez repository
1c68c66 
`fez` was a fork of `rpm-rs` with a number of maintenance fixes. This
commit takes those maintenance fixes and ports them into `rpm-rs`
@cmeister2
Copy link
Collaborator Author

mit: there is a stray TODO that should be moved to an issue and be references, otherwise LGTM!

Fixed.

@cmeister2 cmeister2 mentioned this pull request Jul 19, 2022
Closed
drahnr
drahnr reviewed Jul 19, 2022
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
drahnr
drahnr reviewed Jul 19, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
drahnr
drahnr previously approved these changes Jul 20, 2022
View reviewed changes
@cmeister2
Set MSRV to 1.57.0 in Cargo.toml
d5165a5 
Allow tags with a v-prefix if necessary.
Remove commented out code until the necessary tokens are obtained.
@cmeister2
Copy link
Collaborator Author

@drahnr @Shinyzenith just need your reapproval whenever is convenient!

@Shinyzenith Shinyzenith merged commit 406556a into master Jul 20, 2022
@dralley dralley deleted the md/updates branch December 16, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drahnr drahnr drahnr approved these changes

@Shinyzenith Shinyzenith Shinyzenith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmeister2 @Shinyzenith @drahnr