Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functionality for comparing EVRs / versions #131

Merged
merged 1 commit into from
May 28, 2024
Merged

Functionality for comparing EVRs / versions #131

merged 1 commit into from
May 28, 2024

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented Apr 24, 2023 •
edited
Loading

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

dralley
dralley commented Apr 24, 2023
View reviewed changes
src/version_compare.rs Outdated Show resolved Hide resolved
@dralley
Copy link
Collaborator Author

dralley commented May 12, 2023

@drahnr So, you're partial to subcrates over creating a new repo?

I would also like to maybe write a few simple utilities for e.g.

  • dumping the tags present & values of RPM headers
  • doing low-level lints on RPM headers
  • re-packing RPMs

I assume you feel similarly about such a set of rpm-utils?

@drahnr
Copy link
Contributor

drahnr commented May 12, 2023

I think all of them could become part of this repository in a single workspace, but ultimately I'll leave that up to you

@dralley dralley force-pushed the vercmp branch 5 times, most recently from 4311a89 to 6804be3 Compare May 25, 2024 17:35
@dralley dralley marked this pull request as ready for review May 25, 2024 17:35
@dralley dralley requested a review from drahnr May 25, 2024 17:36
@dralley
Copy link
Collaborator Author

dralley commented May 25, 2024 •
edited
Loading

I'm not against making this its own crate, but I'm not really in favor of doing so immediately. Maybe a bit further down the line?

@dralley dralley force-pushed the vercmp branch 4 times, most recently from 6be79e8 to fe3a94d Compare May 25, 2024 17:46
@dralley dralley enabled auto-merge (rebase) May 25, 2024 17:52
@dralley dralley force-pushed the vercmp branch 5 times, most recently from fcf1c9b to d1c9340 Compare May 28, 2024 03:12
drahnr
drahnr reviewed May 28, 2024
View reviewed changes
src/version.rs Outdated Show resolved Hide resolved
drahnr
drahnr reviewed May 28, 2024
View reviewed changes
src/version.rs Show resolved Hide resolved
drahnr
drahnr requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, otherwise LGTM

@dralley dralley requested a review from drahnr May 28, 2024 13:45
@dralley dralley merged commit bc7b448 into rpm-rs:master May 28, 2024
15 checks passed
@dralley dralley deleted the vercmp branch May 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dralley @drahnr