Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the build_time method, use source_date for clamping all package times #157

Merged
merged 8 commits into from
Jun 14, 2023

Conversation

newpavlov
Copy link
Contributor

@newpavlov newpavlov commented Jun 2, 2023

The package build time is now gets clamped by date provided to the source_date method.

@newpavlov newpavlov force-pushed the source_date_epoch branch 3 times, most recently from 6276296 to bef50d0 Compare June 2, 2023 15:56
src/rpm/builder.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drahnr @cmeister2 Please evaluate in the context of #156, do you think it's OK to squash build_time and source_date into one option?

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting consensus on #156 (comment)

@newpavlov
Copy link
Contributor Author

@dralley
Any updates? IIUC you've agreed in the issue that we need proper bitwise reproducible builds.

{
name: impl AsRef<str>,
entry: impl AsRef<str>,
timestamp: impl TryInto<Timestamp, Error = impl Debug>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drahnr Can you live with this?

CHANGELOG.md Outdated Show resolved Hide resolved
src/rpm/package.rs Outdated Show resolved Hide resolved
@dralley
Copy link
Collaborator

dralley commented Jun 13, 2023

build_and_sign() ought to use the source_date_epoch timestamp during signing

@newpavlov
Copy link
Contributor Author

build_and_sign() ought to use the source_date_epoch timestamp during signing

It already does, no? Or have I missed something?

@dralley
Copy link
Collaborator

dralley commented Jun 13, 2023

I missed that part. In that case can we just replace sde with self.source_date_epoch? It's much clearer.

@dralley
Copy link
Collaborator

dralley commented Jun 13, 2023

Also, if we're passing our own object rather than "just" an epoch value, source_date might be better honestly.

@newpavlov
Copy link
Contributor Author

In that case can we just replace sde with self.source_date_epoch?

if we're passing our own object rather than "just" an epoch value, source_date might be better honestly.

Done.

@newpavlov newpavlov changed the title Remove the build_time method and rename source_date to source_date_epoch Remove the build_time method, use source_date for clamping all package times Jun 13, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one last comment about changelog

@dralley dralley merged commit 9498e02 into rpm-rs:master Jun 14, 2023
@newpavlov newpavlov deleted the source_date_epoch branch June 14, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants