-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the build_time method, use source_date for clamping all package times #157
Conversation
6276296
to
bef50d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drahnr @cmeister2 Please evaluate in the context of #156, do you think it's OK to squash build_time
and source_date
into one option?
bef50d0
to
08046e5
Compare
08046e5
to
e1a7431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting consensus on #156 (comment)
67eb7cc
to
9d7cbdb
Compare
@dralley |
{ | ||
name: impl AsRef<str>, | ||
entry: impl AsRef<str>, | ||
timestamp: impl TryInto<Timestamp, Error = impl Debug>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drahnr Can you live with this?
|
It already does, no? Or have I missed something? |
I missed that part. In that case can we just replace |
Also, if we're passing our own object rather than "just" an epoch value, |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one last comment about changelog
The package build time is now gets clamped by date provided to the
source_date
method.