Update dependencies & new release #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
update-deps
branch
3 times, most recently
from
039d755
to
887a3aa
Compare
dralley
commented
Mar 3, 2024
| ### Breaking Changes | ||
|
|
||
| - Minimum supported Rust version updated to 1.71 |
There was a problem hiding this comment.
env_logger apparently bumped their MSRV and was causing issues when built on lower versions.
There was a problem hiding this comment.
Since it's only a dev dep, I am not sure we should bump Marv, but rather stick to 0.10.x?
There was a problem hiding this comment.
🤷 We certainly could. I figured a 7 months old version was still at least reasonable
dralley
commented
Mar 3, 2024
| #[cfg(feature = "signature-pgp")] | ||
| pub fn signature_key_id(&self) -> Result<Option<String>, Error> { | ||
| pub fn signature_key_ids(&self) -> Result<Vec<String>, Error> { |
There was a problem hiding this comment.
rpgp changed the underlying API here to reflect that signatures can apparently have more than one issuer / key ID.
drahnr
reviewed
Mar 3, 2024
| } | ||
| } | ||
| result | ||
| } else { |
There was a problem hiding this comment.
I think some logic got removed, could you explain a bit why it's not needed?
There was a problem hiding this comment.
Never mind, it got moved down
drahnr
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Checklist
--all-featuresenabled