Use proper flag semantics instead of passing around raw integers #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
changed the title
|
Yes, supposedly |
dralley
force-pushed
the
flag-semantics
branch
2 times, most recently
from
42e204f
to
3db85ac
Compare
drahnr
reviewed
May 18, 2023
src/rpm/package.rs
Outdated
| @@ -819,7 +821,7 @@ impl RPMPackageMetadata { | |||
| mode: mode.into(), | |||
| modified_at: utc.timestamp_opt(mtime as i64, 0u32).unwrap(), // shouldn't fail as we are using 0 nanoseconds | |||
| digest, | |||
| category: FileCategory::from_u32(flags).unwrap_or_default(), | |||
| flags: FileFlags::from_bits(flags).expect("Unexpected rpm file flags found"), | |||
There was a problem hiding this comment.
Should be an error, since there it's within a try_fold anyways, panic seems unnecessary.
drahnr
requested changes
May 18, 2023
drahnr
approved these changes
May 18, 2023
|
FWIW, while it's still drafted I don't necessarily expect a review, still making some changes |
dralley
changed the title
dralley
force-pushed
the
flag-semantics
branch
2 times, most recently
from
f3945ec
to
3f0c3fd
Compare
dralley
commented
May 18, 2023
| let algorithm = self.get_file_digest_algorithm().unwrap_or_default(); | ||
| let algorithm = self | ||
| .get_file_digest_algorithm() | ||
| .unwrap_or(DigestAlgorithm::Md5); |
There was a problem hiding this comment.
Change: deleted Default impl for DigestAlgorithm as it should probably be contextual
Change: renamed a few fields named after sense to flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52