New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented change in python API #360
Comments
Thank you for the report. It sounds critical. |
I made a PR #362 to fix this. |
That looks good to me. I have changed the code where I found this to use the constants rather than unpacking, so it works with both old and new version. Now the fourth item is documented, so I'm happy. |
@kontura This can be closed now yes? |
Should a new issue be filed for my comment on the PR?
|
There is more tuples like this: https://github.com/rpm-software-management/createrepo_c/blob/master/src/python/createrepo_c/__init__.py#L100-L118 plus undocumented I am not sure. Perhaps we could convert it together with the addition of new elements (if that ever happens). |
Version 0.21.1 introduced changes in the python API for accessing files in a particular package. The tuple describing a file entry grew from 3 items to 4. I have not found any documentation on what the fourth item is, and there is no
cr.FILE_ENTRY_
constant to access it.This change breaks backwards compatibility if anyone is using code like:
Here's a small piece of code to replicate the change:
The text was updated successfully, but these errors were encountered: