Fix change in python API of package files #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file digest should be present only when loaded to preserve API. The digests are present only when specifically parsing filelists-ext.
dralley
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Seems OK to me. If the digest is only present when you deliberately act to parse a different file, then there shouldn't be a breaking change for existing code.
However to avoid this in the future maybe it makes sense to return a class/dataclass rather than a tuple, so that data can be added without breaking API. Maybe for 1.0? (not backportable obviously)
kontura
added a commit
to kontura/createrepo_c
that referenced
this pull request
Oct 4, 2023
The fix in rpm-software-management#362 resolved the situation when getting pkg files from python. We need to also fix setting pkg files. Make the digest optional in order to still support files without it.
kontura
added a commit
to kontura/createrepo_c
that referenced
this pull request
Oct 5, 2023
The fix in rpm-software-management#362 resolved the situation when getting pkg files from python. We need to also fix setting pkg files. Make the digest optional in order to still support setting files without it.
kontura
added a commit
that referenced
this pull request
Oct 6, 2023
The fix in #362 resolved the situation when getting pkg files from python. We need to also fix setting pkg files. Make the digest optional in order to still support setting files without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was introduced in #316
For: #360